Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding timestamp features #141

Merged
merged 10 commits into from
Jan 7, 2023
Merged

adding timestamp features #141

merged 10 commits into from
Jan 7, 2023

Conversation

clewis7
Copy link
Collaborator

@clewis7 clewis7 commented Dec 10, 2022

addresses #127

human readable timestamp added when item added to dataframe and ran time stamp is added when item is ran

just trying to get back into the swing of things, thought this would be a good one to implement!!

mesmerize_core/algorithms/cnmf.py Outdated Show resolved Hide resolved
mesmerize_core/batch_utils.py Outdated Show resolved Hide resolved
mesmerize_core/batch_utils.py Outdated Show resolved Hide resolved
@kushalkolar
Copy link
Collaborator

linux test failing but windows test passing? I don't even 😮

@clewis7
Copy link
Collaborator Author

clewis7 commented Dec 20, 2022

I think everything should be fixed here, let me know if there is anything else :)

kushalkolar
kushalkolar previously approved these changes Dec 21, 2022
Copy link
Collaborator

@kushalkolar kushalkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge if CI passes

@kushalkolar
Copy link
Collaborator

CI is failing because new numpy deprecated numpy.int and caiman uses them 🤦‍♂️

@kushalkolar kushalkolar changed the base branch from master to v0.1-dev January 7, 2023 00:39
@kushalkolar kushalkolar added this to the v0.1 release milestone Jan 7, 2023
@kushalkolar kushalkolar changed the base branch from v0.1-dev to master January 7, 2023 06:05
@kushalkolar kushalkolar dismissed their stale review January 7, 2023 06:05

The base branch was changed.

@kushalkolar kushalkolar merged commit 80e34f3 into master Jan 7, 2023
@kushalkolar
Copy link
Collaborator

thanks! @clewis7

@kushalkolar kushalkolar deleted the timestamp branch January 8, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants