Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splitting reconstructed movie into two functions #58

Merged
merged 6 commits into from
Jul 12, 2022

Conversation

clewis7
Copy link
Collaborator

@clewis7 clewis7 commented Jun 23, 2022

cnmf extension for getting reconstructed movie is now two separate functions

get_reconstructed_movie() only returns (A x C)

get_reconstructed_background() only returns (b x f)

in order to get reconstructed movie as before, using kwarg arg background_bool = True", would need to simply call both get_reconstructed_movie() and get_reconstructed_background() and then add them together!

@kushalkolar kushalkolar added this to the v0.1 milestone Jul 3, 2022
@clewis7
Copy link
Collaborator Author

clewis7 commented Jul 9, 2022

get_reconstructed_movie.-2022-07-08_20.19.31.mp4

@clewis7
Copy link
Collaborator Author

clewis7 commented Jul 9, 2022

get_reconstructed_background.-2022-07-08_20.24.28.mp4

@clewis7
Copy link
Collaborator Author

clewis7 commented Jul 9, 2022

get_reconstructed_full-2022-07-08_20.26.26.mp4

@clewis7
Copy link
Collaborator Author

clewis7 commented Jul 9, 2022

get_residuals.-2022-07-08_20.27.59.mp4

@kushalkolar
Copy link
Collaborator

thanks! tested and works on my end!

@kushalkolar kushalkolar merged commit c232995 into master Jul 12, 2022
@kushalkolar kushalkolar deleted the reconstructed_movie_ext branch November 8, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants