Sync neo-core

[Tommo-L]

Close #412

• Remove System.Iterator.Concat, System.Enumerator.Concat and System.Callback.*
• Add System.Storage.FindKeys and OracleResponseCode
• Update CallFlags.cs, Contract.Call

[erikzhang]

Maybe we should wait for neo-project/neo#2167?

[Tommo-L]

We are updating the Contract.Call, need one or two more days.

[shargon]

@ShawnYun could you check why it's failing the Storage UT? Test_FindKeys

[cloud8little]

@ShawnYun could you check why it's failing the Storage UT? Test_FindKeys

The neo-core is still 3.0.0-CI01130, FindKeys is out-of-date already.

[erikzhang]

Wait for neo-project/neo#2211

[shargon]

Ready to review

[erikzhang]

@neo-project/ngd-shanghai Test.

[cloud8little]

@neo-project/ngd-shanghai Test.

Under testing.

[cloud8little]

Deploy a contract like below, it seems when return value is void, it will throw exception.

Contract:

       public static string test2()
        {
            return "test2";
        }

        public static void _deploy(bool update)
        {
            Storage.Put(Storage.CurrentContext,"this","is");
        }

        public static void test3(int a)
        {
            a = a + 2;
        }

        public static int testInt(int a)
        {
            return 1;
        }

        public static void testvoidinputstring(string a)
        {
            a = a + "abc";
        }

[shargon]

@cloud8little this doesn't happen before this PR? or happen without _deploy? Maybe it is related to neo-project/neo-modules#458 ?

[cloud8little]

@cloud8little this doesn't happen before this PR? or happen without _deploy? Maybe it is related to neo-project/neo-modules#458 ?

at least we can deploy nep17 contract successfully which also have _deploy by default. I tried without _deploy in the contract. same error.

[superboyiii]

The same from my side. _deploy works well, but void can't retrun without error.

[erikzhang]

The compiler didn't emit the opcode INITSSLOT or INITSLOT.

[cloud8little]

@shargon The reason is parameters can not be changed in the function. It is not the return void error. For experiment you can change the test contract a bit as following:

        public static void Testvoid(int a, int b)
        {
            a = a + 2;
        }

I guess it is a legacy issue. Let's discuss/fix in other PRs.

[shargon]

@cloud8little please open a new issue, we can fix it in other PR