Sign the transaction in the InvokeContractVerify method

[chenzhitong]

close #423

[shargon]

tested?

[superboyiii]

Wait for neo-project/neo#2167

[superboyiii]

Let's move on.

[shargon]

Tested?

[cloud8little]

Test result: Fail

• Invoke OracleContract with a random account, it should return false.

• Invoke a new deployed NEP17 contract with owner account, it should return true.
  

[cloud8little]

Conflict need to be resolved.

[vncoelho]

Is there a need to check if these signers are know or unknown as @cloud8little tested?

[cloud8little]

Test Passed:

[Tommo-L]

@cloud8little Did you test it with more than one parameters? It seems it'll fail.

[superboyiii]

@Tommo-L I've tested this and seems multi params are OK.

Demo:

using Neo;
using Neo.SmartContract.Framework;
using Neo.SmartContract.Framework.Services.Neo;
using System;
using System.ComponentModel;
using System.Numerics;

namespace Contract1
{
    [ManifestExtra("Author", "Neo")]
    [ManifestExtra("Email", "[email protected]")]
    [ManifestExtra("Description", "This is a contract example")]
    public class Contract1 : SmartContract
    {
        [DisplayName("Verify")]
        public static event Action<int, int, int> OnVerify;

        static readonly UInt160 Owner = "NUXLF99jdK1v5hsgjL7pwMr4Tm7RXrwK6W".ToScriptHash();

        private static bool IsOwner() => Runtime.CheckWitness(Owner);

        public static bool Verify(int a, int b)
        {
            int c = a + b;
            OnVerify(a, b, c);
            return IsOwner();
        }

        public static string test2()
        {
            return "test2";
        }

        public static void _deploy(bool update)
        {
            Storage.Put(Storage.CurrentContext, "this", "is");
        }

        public static void test3(int a)
        {
            int b = a + 2;
        }

        public static int testInt(int a)
        {
            return 1;
        }

        public static void testvoidinputstring(string a)
        {
            string b = a + "abc";
        }
    }
}

Request:

{
  "jsonrpc": "2.0",
  "method": "invokecontractverify",
  "params": [
    "0xb78526cff2721e611de552ebf4c500e30d966848",
    [
      {
        "type": "Integer",
        "value": "1"
      },
      {
        "type": "Integer",
        "value": "2"
      }
    ],
    [
      {
        "account": "NUXLF99jdK1v5hsgjL7pwMr4Tm7RXrwK6W",
        "scopes": "CalledByEntry"
      }
    ]
  ],
  "id": 3
}

Response:

{
    "jsonrpc": "2.0",
    "id": 3,
    "result": {
        "script": "VwABQZv2Z84MBHRoaXMMAmlzU0HmPxiEQFYBDBRecSTBQp/CCMobYfKsNidhhQGa4GBADBRecSTBQp/CCMobYfKsNidhhQGa4EH4J+yMQFcBAAwFdGVzdDJwaEBXAQF4Ep5wQFcBARFwaEBXAQF4DANhYmOL2yhwQFcCAnh5nnB4eWhTE8AMBlZlcmlmeUGVAW9hNKBxaUA=",
        "state": "HALT",
        "gasconsumed": "0.0204747",
        "exception": null,
        "stack": [
            {
                "type": "Boolean",
                "value": true
            }
        ]
    }
}

[superboyiii]

Please delete ReturnValue in EmitDynamicCall