Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OracleService.cs #535

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Update OracleService.cs #535

merged 1 commit into from
Mar 3, 2021

Conversation

chenzhitong
Copy link
Member

@chenzhitong chenzhitong commented Mar 3, 2021 •
edited
Loading

close #494

shargon
shargon reviewed Mar 3, 2021
View reviewed changes
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you test it if exit invoke OnStop ?

@chenzhitong
Copy link
Member Author

chenzhitong commented Mar 3, 2021 •
edited
Loading

work fine on mine.

2021-03-03_16-31-26.mp4

@chenzhitong
Copy link
Member Author

Could you test it if exit invoke OnStop ?

yes

2021-03-03_16-42-07.mp4

@ProDog ProDog self-requested a review March 3, 2021 09:20
@cloud8little
Copy link
Contributor

Test passed. Exit successful when not start oracle service.

@shargon shargon merged commit a205ba5 into neo-project:master Mar 3, 2021
@superboyiii superboyiii mentioned this pull request Mar 5, 2021
Closed
27 tasks
joeqian10 pushed a commit to joeqian10/neo-modules that referenced this pull request Apr 7, 2021
@chenzhitong @joeqian10
Update OracleService.cs (neo-project#535)
0d2a51e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

@steven1227 steven1227 steven1227 approved these changes

@ProDog ProDog ProDog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using the exit command after installing the Oracle plugin causes the cli to become unresponsive
5 participants
@chenzhitong @cloud8little @shargon @steven1227 @ProDog