Fix workflow #857
Merged
Fix workflow #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superboyiii
approved these changes
Dec 6, 2023
shargon
approved these changes
Dec 6, 2023
| @@ -46,7 +46,7 @@ jobs: | |||
| id: get_version | |||
| run: | | |||
| sudo apt install xmlstarlet | |||
| find -name Directory.Build.props | xargs xmlstarlet sel -N i=http://schemas.microsoft.com/developer/msbuild/2003 -t -v "concat('::set-output name=version::v',//i:VersionPrefix/text())" | xargs echo | |||
| find -maxdepth 1 -name Directory.Build.props | xargs xmlstarlet sel -N i=http://schemas.microsoft.com/developer/msbuild/2003 -t -v "concat('::set-output name=version::v',//i:VersionPrefix/text())" | xargs echo | |||
There was a problem hiding this comment.
Could of did run: echo "VERSION=${GITHUB_REF/refs\/tags\/v/}" >> $GITHUB_ENV than do
dotnet build someproject.csproj -p:VersionPrefix=${VERSION}
This get new tag version and sets VersionPrefix in a project
There was a problem hiding this comment.
We are using this workflow to create new tag now, so couldn't find new tags from git. I have no ideas how to make the workflow more usable, since it has already been a hardcoded solution.
Jim8y
added a commit
to Jim8y/neo-modules
that referenced
this pull request
Dec 13, 2023
* 'master' of github.com:neo-project/neo-modules: Fix workflow (neo-project#857) Fix stack exception name (neo-project#855) update workflow (neo-project#856) Refac build configs (neo-project#846) Hotfix for neo-project#850 (neo-project#853) Fix RpcNativeContract (neo-project#851)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix workflow