Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix response from getversion due to WS removal #859

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Conversation

vncoelho
Copy link
Member

@vncoelho vncoelho commented Jan 3, 2024

No description provided.

@cschuchardt88
Copy link
Member

Can you post reminders on RestServer and WebSocketServer PRs?

This was referenced Jan 3, 2024
Jim8y
Jim8y previously approved these changes Jan 4, 2024
@Jim8y
Copy link
Contributor

Jim8y commented Jan 4, 2024

We still have other places that contain wsport, mind to remove them as well?

@shargon
Copy link
Member

shargon commented Jan 4, 2024

We still have other places that contain wsport, mind to remove them as well?

If there are more we should remove them together

@vncoelho
Copy link
Member Author

vncoelho commented Jan 4, 2024

We still have other places that contain wsport, mind to remove them as well?

I am not sure

@vncoelho
Copy link
Member Author

vncoelho commented Jan 4, 2024

Maybe rpcclient, lets double check

@cschuchardt88
Copy link
Member

Try compiling the whole solution, and check for errors. After you update all the packages.

@vncoelho
Copy link
Member Author

vncoelho commented Jan 4, 2024

This was not compilation error,@cschuchardt88

@cschuchardt88
Copy link
Member

But if it errors, it will let you know if anymore exist.

@vncoelho
Copy link
Member Author

vncoelho commented Jan 4, 2024

I was still setting up our tools that creates neo-cli client and add plugins.

I will soon compile again, but since I was able to add the plugin I think that the library does not provide compilation error, just when called.
I also added RPCClient to it.

However, thinking about the logic there must be a similar call there. Later I will check.

@Jim8y
Copy link
Contributor

Jim8y commented Jan 4, 2024

Just do a wsport search you will find them.

@cschuchardt88
Copy link
Member

You want to be searching for ws and websocket

@superboyiii
Copy link
Member

62bb544de4aeedba1e708995542dd5a
All these should be removed.

@shargon shargon merged commit c4f50a9 into master Jan 4, 2024
2 of 3 checks passed
@shargon shargon deleted the vncoelho-patch-2 branch January 4, 2024 09:32
Jim8y added a commit to Jim8y/neo-modules that referenced this pull request Jan 10, 2024
* 'master' of github.com:neo-project/neo-modules:
  Ensure max length (neo-project#845)
  Update .editorconfig and run code analyze (neo-project#866)
  Added AspNetCore (neo-project#863)
  RcpServer: Fixed CORS and Basic Auth (neo-project#812)
  Fix response from getversion due to WS removal (neo-project#859)
  Local dev setup (neo-project#861)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants