Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Move SystemLog to neo-cli #587

Merged
merged 22 commits into from
May 26, 2020
Merged

Move SystemLog to neo-cli #587

merged 22 commits into from
May 26, 2020

Conversation

joeqian10
Copy link
Contributor

@joeqian10 joeqian10 commented May 15, 2020 •
edited
Loading

Close #228.

@joeqian10 joeqian10 requested a review from erikzhang May 15, 2020 10:40
erikzhang
erikzhang reviewed May 15, 2020
View reviewed changes
neo-cli/CLI/Logger.cs Outdated Show resolved Hide resolved
neo-cli/CLI/Logger.cs Outdated Show resolved Hide resolved
shargon
shargon reviewed May 15, 2020
View reviewed changes
neo-cli/Settings.cs Outdated Show resolved Hide resolved
@joeqian10
Copy link
Contributor Author

Help needed:
image

@Tommo-L Tommo-L mentioned this pull request May 20, 2020
Merged
@Tommo-L
Copy link
Contributor

Tommo-L commented May 20, 2020

Waiting for neo-project/neo#1656

Tommo-L
Tommo-L reviewed May 21, 2020
View reviewed changes
neo-cli/neo-cli.csproj Outdated Show resolved Hide resolved
@Tommo-L Tommo-L mentioned this pull request May 21, 2020
Merged
shargon
shargon previously approved these changes May 21, 2020
View reviewed changes
@erikzhang
Copy link
Member

Should we remove the --mainnet and --testnet options first?

@vncoelho
Copy link
Member

I think it is good to remove as you suggested and discussed above, @erikzhang.

@vncoelho
Copy link
Member

However, @erikzhang, it is now blocking neo-project/neo-modules#246 (review).
Perhaps better to merge and open a new PR.

vncoelho
vncoelho previously approved these changes May 21, 2020
View reviewed changes
@shargon shargon dismissed stale reviews from vncoelho and themself via b1355e4 May 21, 2020 18:41
shargon
shargon previously approved these changes May 21, 2020
View reviewed changes
erikzhang
erikzhang suggested changes May 22, 2020
View reviewed changes
neo-cli/Settings.cs Outdated Show resolved Hide resolved
nicolegys
nicolegys approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@nicolegys nicolegys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed.

Situations:
1."ConsoleOutput": false, "Active": false
2."ConsoleOutput": false, "Active": true
3."ConsoleOutput": true, "Active": true

Folders in Logs_xxx:
image

@shargon shargon merged commit ecc0110 into neo-project:master May 26, 2020
@ProDog ProDog mentioned this pull request Jun 5, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tommo-L Tommo-L Tommo-L left review comments

@shargon shargon shargon approved these changes

@erikzhang erikzhang erikzhang approved these changes

@nicolegys nicolegys nicolegys approved these changes

@vncoelho vncoelho vncoelho left review comments

Assignees
No one assigned
Labels
blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move SystemLog to a neo-cli command
7 participants
@joeqian10 @Tommo-L @erikzhang @vncoelho @shargon @nicolegys @superboyiii