Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

Call Token #382

Merged
merged 10 commits into from
Dec 18, 2020
Merged

Call Token #382

merged 10 commits into from
Dec 18, 2020

Conversation

erikzhang
Copy link
Member

No description provided.

@erikzhang erikzhang mentioned this pull request Dec 17, 2020
Closed
@shargon
Copy link
Member

shargon commented Dec 17, 2020

How It will be used?

@Qiao-Jin Qiao-Jin mentioned this pull request Dec 17, 2020
Closed
@superboyiii superboyiii mentioned this pull request Dec 17, 2020
Closed
@erikzhang
Copy link
Member Author

How It will be used?

I will add MethodToken table in NefFile.

0x0001: <hash> <methodName> <paramCount> <rvCount> <flags>
0x0002: <hash> <methodName> <paramCount> <rvCount> <flags>
0x0003: <hash> <methodName> <paramCount> <rvCount> <flags>
...

Then we can call other contracts by CALLT:

PUSH <param1>
PUSH <param2>
CALLT 0x0002

@shargon
Copy link
Member

shargon commented Dec 17, 2020

I will add MethodToken table in NefFile.

Then maybe we will need more than 4 bytes in NefFile.

@erikzhang
Copy link
Member Author

Why? It only takes up 1 byte.

@shargon
Copy link
Member

shargon commented Dec 17, 2020

Why? It only takes up 1 byte.

3 more seems weird :P

shargon
shargon reviewed Dec 18, 2020
View reviewed changes
src/neo-vm/ExecutionContext.cs Show resolved Hide resolved
src/neo-vm/ExecutionEngine.cs Outdated Show resolved Hide resolved
src/neo-vm/ExecutionEngine.cs Show resolved Hide resolved
@erikzhang erikzhang merged commit defb237 into master Dec 18, 2020
@erikzhang erikzhang deleted the CALLT branch December 18, 2020 09:22
@cloud8little cloud8little mentioned this pull request Dec 28, 2020
Closed
@fyrchik fyrchik mentioned this pull request Dec 29, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikzhang @shargon