Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notary native contract #2897

Open
roman-khimov opened this issue Sep 6, 2023 · 2 comments
Open

Notary native contract #2897

roman-khimov opened this issue Sep 6, 2023 · 2 comments
Labels
discussion Initial issue state - proposed but not yet accepted
Milestone

Comments

@roman-khimov
Copy link
Contributor

Summary or problem description
Add a new native contract, Notary, with all of the associated logic from #1573 (comment)

Do you have any solution you want to propose?
The GAS locking mechanics of it is rather trivial, verify is a little more complex and it affects the NotaryAssisted attribute a bit as well (dynamic fee).

Target Neo Version

  • Neo 3.7

Where in the software does this update applies to?

  • Native contracts

Depends on #2896 and #2895. With this implemented C# will be able to process NeoFS sidechains.

@roman-khimov roman-khimov added the discussion Initial issue state - proposed but not yet accepted label Sep 6, 2023
@vncoelho
Copy link
Member

Did you consider #2646 and #2661?

@roman-khimov
Copy link
Contributor Author

They have too many things at the same time, some parts from them are already merged (like attributes) and there even were bugs found and fixed during the process. We're going step by step and piece by piece now. In fact, this was the way Notary was implemented in NeoGo way back when, there was no single monstrous PR delivering all of it, we've moved component by component (there is enough of independent parts there).

The main thing is that

With this implemented C# will be able to process NeoFS sidechains.

Even though it still won't be able to process Notary P2P payloads (but that'd be the next step).

@roman-khimov roman-khimov added this to the v3.7.0 milestone Nov 16, 2023
AnnaShaleva added a commit that referenced this issue Mar 19, 2024
AnnaShaleva added a commit that referenced this issue Mar 19, 2024
Close #2897. Depends on #3175.

Signed-off-by: Anna Shaleva <[email protected]>
@roman-khimov roman-khimov modified the milestones: v3.7.0, v3.8.0 May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Initial issue state - proposed but not yet accepted
Projects
None yet
Development

No branches or pull requests

2 participants