Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MaxTraceableBlocks to protocol #2042

Conversation

Qiao-Jin
Copy link
Contributor

@Qiao-Jin Qiao-Jin commented Nov 3, 2020

shargon
shargon previously approved these changes Nov 3, 2020
src/neo/Wallets/Wallet.cs Outdated Show resolved Hide resolved
@erikzhang
Copy link
Member

We only agreed to move MaxTraceableBlocks.

@vncoelho
Copy link
Member

vncoelho commented Nov 3, 2020

I think moving MaxValidUntilBlockIncrement sounds good if just accessing the storage locally, we can cache this value every block persist. It will not change much but looks to be a good practice.

@Qiao-Jin
Copy link
Contributor Author

Qiao-Jin commented Nov 4, 2020

We only agreed to move MaxTraceableBlocks.

Have Resumed Transaction.MaxValidUntilBlockIncrement

@Qiao-Jin
Copy link
Contributor Author

Qiao-Jin commented Nov 5, 2020

Can we merge this one?

@shargon shargon merged commit 402e9b1 into neo-project:master Nov 5, 2020
roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Nov 5, 2020
Follow neo-project/neo#2042, use 2102400 setting for mainnet/testnet and
200000 for private networks.
roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Nov 5, 2020
roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Nov 6, 2020
Follow neo-project/neo#2042, use 2102400 setting for mainnet/testnet and
200000 for private networks.
roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Nov 6, 2020
@Qiao-Jin Qiao-Jin changed the title Move MaxValidUntilBlockIncrement & MaxTraceableBlocks to protocol Move MaxTraceableBlocks to protocol Nov 10, 2020
ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
…o-project#2042)

* Move MaxValidUntilBlockIncrement & MaxTraceableBlocks to protocol

* Add comments

* Revert MaxValidUntilBlockIncrement

Co-authored-by: Jin Qiao <[email protected]>
Co-authored-by: Shargon <[email protected]>
Co-authored-by: Vitor Nazário Coelho <[email protected]>
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
…o-project#2042)

* Move MaxValidUntilBlockIncrement & MaxTraceableBlocks to protocol

* Add comments

* Revert MaxValidUntilBlockIncrement

Co-authored-by: Jin Qiao <[email protected]>
Co-authored-by: Shargon <[email protected]>
Co-authored-by: Vitor Nazário Coelho <[email protected]>
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants