Change ContractManifest serialization #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AnnaShaleva @roman-khimov Please check it. |
|
This should work and it also makes working with manifest easier for contracts. |
|
As I told @roman-khimov this only solve one issue, the manifest one, but if we have discrepancies in json, and people use the json syscalls, we will have the same problem. |
|
Let's solve these one by one, this PR definitely improves things at least in one area. |
shargon
previously approved these changes
Jan 20, 2021
erikzhang
commented
Jan 21, 2021
shargon
previously approved these changes
Jan 21, 2021
erikzhang
commented
Jan 21, 2021
shargon
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2181