-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coverage #3155
Fix coverage #3155
Conversation
this will be good if fixed |
|
maybe version v2.2.3 |
"You can also skip using the file option and coveralls will try to find all supported coverage files and combine their data." |
I think that now it's fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is fixed, it was good to check their release info.
Maybe we can also leave the file config empty and delete it.
It only take cryptography https://coveralls.io/builds/65868879 |
I just tried something to be sure, let's see the result. Recently I got some problems on devcontainer if these commands were not executed before |
Since the last command is just used for maybe remove the rest of the parameter for the other matrix.os - name: Test
run: |
find tests -name *.csproj | xargs -I % dotnet add % package coverlet.msbuild
dotnet test /p:CollectCoverage=true /p:CoverletOutputFormat=lcov /p:CoverletOutput=${GITHUB_WORKSPACE}/coverage/lcov /p:MergeWith="./coverage/lcov.net7.0.info"
- name: Coveralls
if: matrix.os == 'ubuntu-latest'
uses: coverallsapp/[email protected]
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
file: ./coverage/lcov.net7.0.info
``` |
why we need merge? Which additional reports should be added? |
Please @vncoelho wait for my wait for review |
The doc said that it's required to merge the test one by one, and convert to the desired format in the last one: https:/coverlet-coverage/coverlet/blob/master/Documentation/Examples/MSBuild/MergeWith/HowTo.md |
I saw this as well later |
I think you should use the default as well without specifying, it will be json
|
It works now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect, I think you can change to
- name: Test for Win and Mac
if: matrix.os == 'windows-latest' || matrix.os == 'macos-latest'
run: |
dotnet test
- name: Test for Coveralls Only
if: matrix.os == 'ubuntu-latest'
This should also be done in modules and devpack |
The coverage is sometimes random, this pr aims to fix it