Fix optional cookie #267
Merged
Fix optional cookie #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fix prevents the app from crashing id req.cookies is undefined
|
We'll just need to add to the CLA allowlist and then we'll take a look at this. 🙂 Thanks for the contribution! |
danstarns
added
the
changelog
|
@OskarDamkjaer I stumbled into this bug on the 2.0.0-alpha.x release (published 21 days ago) in npm. This patch has been back-ported into the 2.0.0 branch but is still missing from the npm registry :) |
|
@kristjanmik Is it me you seek of @oskarhane ? :) |
|
Yes, I'm summoning all the Oskars, sorry about that. I'm indeed calling on the power of @oskarhane. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prevent app crash with errors
Cannot read property 'token' of undefinedIssue
yarn workspace neo-push-server startwhat happens
it triggers an error
Cannot read property 'token' of undefinedexpected result
it should run smoothly
Checklist
The following requirements should have been met (depending on the changes in the branch):