Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified spatial property projection #5521

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

darrellwarde
Copy link
Contributor

Description

Simplifies spatial property projection by using an internal lookup table for CRS values rather than depending on the database. Points are now projected just like normal properties! 🎉

Complexity

Complexity: Low

Copy link

changeset-bot bot commented Sep 2, 2024

🦋 Changeset detected

Latest commit: 2e6de36

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@neo4j/graphql Patch
@neo4j/graphql-ogm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@neo4j-team-graphql
Copy link
Collaborator

Performance Report

No Performance Changes

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregate 3404 3404 36 49 1134
aggregations.TopLevelAggregateWithMultipleFields 6802 6802 43 66 1134
aggregations.NestedAggregation 15407 15407 61 88 2174
aggregations.AggregationWithWhere 10833 10833 39 63 2174
aggregations.AggregationWhereWithinNestedRelationships 20097917 20097917 2173 2194 2008534
aggregations.AggregationWhereWithinNestedConnections 20097917 20097917 2105 2100 2008534
aggregations.NestedCountFromMovieToActors 8603 8603 33 54 2174
aggregations.NestedCountFromActorsToMovie 8791 8791 38 41 2174
aggregations.DeeplyNestedCount 10052335 10052335 2734 2519 2008534
aggregations.InterfacesAggregations 6242 6242 46 53 2080
aggregations.InterfacesAggregationsWithTwoFields 11444 11444 82 89 2080
batch-create.BatchCreate 4200 4200 129 162 600
batch-create.BatchCreateSmall 77 77 52 67 11
connect.createAndConnect 6433 6433 151 171 3003
connections.Connection 12951 12951 72 74 2174
connections.NestedConnection 37705 37705 122 175 4516
create.SimpleMutation 7 7 49 55 1
cypher-directive.TopLevelMutationDirective 1135 1135 31 27 1134
delete.SimpleDelete 19401 19401 795 773 1040
delete.NestedDeleteInUpdate 16844 16844 129 147 2040
2871.NestedRelationshipFilter 19869 19856 68 66 4467
2925.SingleRelationshipFilter 5245 5245 36 48 1040
2925.NestedSingleRelationshipFilter 17641 17641 90 90 2174
2925.SingleRelationshipRequiredFilter 5201 5201 34 46 1040
2925.NestedSingleRelationshipRequiredFilter 9361 9361 51 65 1040
query.SimpleQuery 3121 3121 28 31 1040
query.SimpleQueryWithRelationship 15031 15031 48 43 2174
query.QueryWhere 8594 8594 34 39 2164
query.SimpleQueryWithNestedWhere 8743 8743 46 67 2164
query.Nested 10084891 10084891 7368 7335 2008534
query.NestedWithFilter 10064992 10064992 6781 6722 2004000
query.OrFilterOnRelationships 37363 37172 144 167 2168
query.OrFilterOnRelationshipsAndNested 27439 27606 183 228 2168
query.QueryWithNestedIn 14825 14825 48 66 2075
query.NestedConnectionWhere 8703 8703 50 143 2174
query.DeeplyNestedConnectionWhere 8803 8803 70 84 2174
query.DeeplyNestedWithRelationshipFilters 17489 17489 119 144 1596
query.NestedWithRelationshipSingleFilters 3808 3808 180 188 1134
query.Fulltext 64 64 33 43 16
query.FulltextWithNestedQuery 516 516 60 51 84
sorting-and-cypher.TopLevelSortWithCypher 12961 12961 40 44 2174
sorting-and-cypher.TopLevelConnectionSortWithCypher 12961 12961 61 75 2174
sorting-and-cypher.TopLevelSortWithCypherWithNested 13096 13096 54 61 2174
sorting-and-cypher.TopLevelConnectionSortWithCypherWithNested 13096 13096 90 98 2174
sorting-and-cypher.TopLevelSortWithExpensiveCypher 13700 13700 97 123 2174
sorting-and-cypher.TopLevelConnectionSortWithExpensiveCypher 13266 13266 97 140 2174
sorting.SortMultipleTypes 3436 3436 80 91 1040
sorting.SortMultipleTypesWithCypherWithCypher 13321 13321 95 111 2174
sorting.SortOnNestedFields 12951 12951 40 48 2174
sorting.SortDeeplyNestedFields 39785 39785 78 96 4516
sorting.ConnectionWithSort 3271 3271 67 77 1040
unions.SimpleUnionQuery 321 321 63 59 35
unions.SimpleUnionQueryWithMissingFields 293 293 53 58 35
unions.NestedUnion 309975 309975 276 288 33033
unions.NestedUnionWithMissingFields 283949 283949 255 295 33033
update.NestedUpdate 14137 14137 95 114 2002

Old Schema Generation: 27.461s
Schema Generation: 27.780s
Old Subgraph Schema Generation: 29.114s
Subgraph Schema Generation: 28.572s

@darrellwarde darrellwarde merged commit 0ac8bd8 into neo4j:dev Sep 2, 2024
82 of 83 checks passed
@darrellwarde darrellwarde deleted the fix/point-resolver branch September 2, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants