Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete operations inside update with unions #5606

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

angrykoala
Copy link
Member

Description

Fix delete operations inside updates for unions #5599

@angrykoala angrykoala linked an issue Oct 1, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: 910ee92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@neo4j/graphql Patch
@neo4j/graphql-ogm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Oct 1, 2024

Performance Report

No Performance Changes

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregate 3404 3404 37 43 1134
aggregations.TopLevelAggregateWithMultipleFields 6802 6802 50 57 1134
aggregations.NestedAggregation 15407 15407 57 85 2174
aggregations.AggregationWithWhere 10833 10833 43 62 2174
aggregations.AggregationWhereWithinNestedRelationships 20097917 20097917 2376 2451 2008534
aggregations.AggregationWhereWithinNestedConnections 20097917 20097917 2196 2274 2008534
aggregations.NestedCountFromMovieToActors 8603 8603 34 39 2174
aggregations.NestedCountFromActorsToMovie 8791 8791 33 39 2174
aggregations.DeeplyNestedCount 10052335 10052335 2909 2926 2008534
aggregations.InterfacesAggregations 6242 6242 59 50 2080
aggregations.InterfacesAggregationsWithTwoFields 11444 11444 86 85 2080
batch-create.BatchCreate 4200 4200 126 139 600
batch-create.BatchCreateSmall 77 77 56 62 11
connect.createAndConnect 6433 6433 123 165 3003
connections.Connection 12951 12951 78 71 2174
connections.NestedConnection 37705 37705 161 143 4516
create.SimpleMutation 7 7 54 58 1
cypher-directive.TopLevelMutationDirective 1135 1135 36 34 1134
delete.SimpleDelete 19401 19401 673 773 1040
delete.NestedDeleteInUpdate 16844 16844 159 160 1183
2871.NestedRelationshipFilter 19632 19632 55 71 4395
2925.SingleRelationshipFilter 5245 5245 37 45 1040
2925.NestedSingleRelationshipFilter 17641 17641 70 108 2174
2925.SingleRelationshipRequiredFilter 5201 5201 38 53 1040
2925.NestedSingleRelationshipRequiredFilter 9361 9361 52 66 1040
query.SimpleQuery 3121 3121 19 32 1040
query.SimpleQueryWithRelationship 15031 15031 43 60 2174
query.QueryWhere 8564 8564 31 45 2154
query.SimpleQueryWithNestedWhere 8713 8713 45 56 2154
query.Nested 10084891 10084891 6905 6806 2008534
query.NestedWithFilter 10064992 10064992 6894 6633 2004000
query.OrFilterOnRelationships 36640 36482 139 169 1925
query.OrFilterOnRelationshipsAndNested 26713 26913 181 219 1925
query.QueryWithNestedIn 14117 14135 60 69 1839
query.NestedConnectionWhere 8703 8703 51 66 2174
query.DeeplyNestedConnectionWhere 8702 8702 74 99 2174
query.DeeplyNestedWithRelationshipFilters 17357 17357 145 149 1552
query.NestedWithRelationshipSingleFilters 3808 3808 139 181 1134
query.Fulltext 64 64 30 36 16
query.FulltextWithNestedQuery 516 516 39 47 84
sorting-and-cypher.TopLevelSortWithCypher 12961 12961 38 60 2174
sorting-and-cypher.TopLevelConnectionSortWithCypher 12961 12961 62 65 2174
sorting-and-cypher.TopLevelSortWithCypherWithNested 13096 13096 53 67 2174
sorting-and-cypher.TopLevelConnectionSortWithCypherWithNested 13096 13096 92 109 2174
sorting-and-cypher.TopLevelSortWithExpensiveCypher 13725 13705 109 126 2174
sorting-and-cypher.TopLevelConnectionSortWithExpensiveCypher 13266 13266 99 124 2174
sorting.SortMultipleTypes 3436 3436 86 117 1040
sorting.SortMultipleTypesWithCypherWithCypher 13321 13321 96 113 2174
sorting.SortOnNestedFields 12951 12951 42 52 2174
sorting.SortDeeplyNestedFields 39785 39785 77 105 4516
sorting.ConnectionWithSort 3271 3271 72 72 1040
unions.SimpleUnionQuery 321 321 53 62 35
unions.SimpleUnionQueryWithMissingFields 293 293 52 67 35
unions.NestedUnion 309975 309975 261 296 33033
unions.NestedUnionWithMissingFields 283949 283949 289 276 33033
update.NestedUpdate 14137 14137 94 111 2002

Old Schema Generation: 27.259s
Schema Generation: 28.053s
Old Subgraph Schema Generation: 29.117s
Subgraph Schema Generation: 29.897s

@angrykoala angrykoala merged commit d304808 into dev Oct 1, 2024
80 checks passed
@angrykoala angrykoala deleted the 5599-update-delete-operation-fails-for-unions branch October 1, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ... Delete operation fails for unions
3 participants