Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove connection wrapper from vector index #5633

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

angrykoala
Copy link
Member

Description

Remove connection wrapper on vector queries

Previous:

query MovieVectorQuery($vector: [Float!]!) {
    myVectorQuery(vector: $vector) {
        moviesConnection {
            edges {
                cursor
                score
                node {
                    title
                }
            }
        }
    }
}

Now:

query MovieVectorQuery($vector: [Float!]!) {
    myVectorQuery(vector: $vector) {
        edges {
            cursor
            score
            node {
                title
            }
        }
    }
}

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: 2509ebc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@neo4j/graphql Minor
@neo4j/graphql-ogm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

darrellwarde
darrellwarde previously approved these changes Oct 8, 2024
Copy link
Contributor

@darrellwarde darrellwarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! When we have come to a decision, I would embellish the changesets message with the fact that this is the final breaking change of the beta period of this feature, and marks the stable release of vector index support.

packages/graphql/src/schema/resolvers/query/vector.ts Outdated Show resolved Hide resolved
@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Oct 8, 2024

Performance Report

No Performance Changes

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregate 3404 3404 45 49 1134
aggregations.TopLevelAggregateWithMultipleFields 6802 6802 50 56 1134
aggregations.NestedAggregation 15407 15407 59 85 2174
aggregations.AggregationWithWhere 10833 10833 41 58 2174
aggregations.AggregationWhereWithinNestedRelationships 20097917 20097917 2103 2205 2008534
aggregations.AggregationWhereWithinNestedConnections 20097917 20097917 2066 2072 2008534
aggregations.NestedCountFromMovieToActors 8603 8603 32 41 2174
aggregations.NestedCountFromActorsToMovie 8791 8791 34 41 2174
aggregations.DeeplyNestedCount 10052335 10052335 2646 2867 2008534
aggregations.InterfacesAggregations 6242 6242 44 63 2080
aggregations.InterfacesAggregationsWithTwoFields 11444 11444 75 87 2080
batch-create.BatchCreate 4200 4200 185 142 600
batch-create.BatchCreateSmall 77 77 58 59 11
connect.createAndConnect 6433 6433 142 176 3003
connections.Connection 12951 12951 62 91 2174
connections.NestedConnection 37705 37705 117 143 4516
create.SimpleMutation 7 7 51 57 1
cypher-directive.TopLevelMutationDirective 1135 1135 30 33 1134
delete.SimpleDelete 19401 19401 671 662 1040
delete.NestedDeleteInUpdate 16844 16844 129 153 1179
2871.NestedRelationshipFilter 19632 19735 52 63 4395
2925.SingleRelationshipFilter 5245 5245 38 47 1040
2925.NestedSingleRelationshipFilter 17641 17641 75 93 2174
2925.SingleRelationshipRequiredFilter 5201 5201 37 43 1040
2925.NestedSingleRelationshipRequiredFilter 9361 9361 57 61 1040
query.SimpleQuery 3121 3121 22 24 1040
query.SimpleQueryWithRelationship 15031 15031 42 43 2174
query.QueryWhere 8564 8564 34 41 2154
query.SimpleQueryWithNestedWhere 8713 8713 46 59 2154
query.Nested 10084891 10084891 6849 9056 2008534
query.NestedWithFilter 10064992 10064992 6648 7011 2004000
query.OrFilterOnRelationships 36682 37241 143 165 1939
query.OrFilterOnRelationshipsAndNested 26755 27672 182 242 1939
query.QueryWithNestedIn 14144 14948 86 65 1848
query.NestedConnectionWhere 8703 8703 54 64 2174
query.DeeplyNestedConnectionWhere 8702 8793 75 94 2174
query.DeeplyNestedWithRelationshipFilters 17357 17489 131 156 1552
query.NestedWithRelationshipSingleFilters 3808 3808 133 226 1134
query.Fulltext 64 64 36 37 16
query.FulltextWithNestedQuery 516 516 41 52 84
sorting-and-cypher.TopLevelSortWithCypher 12961 12961 39 52 2174
sorting-and-cypher.TopLevelConnectionSortWithCypher 12961 12961 62 65 2174
sorting-and-cypher.TopLevelSortWithCypherWithNested 13096 13096 55 61 2174
sorting-and-cypher.TopLevelConnectionSortWithCypherWithNested 13096 13096 90 109 2174
sorting-and-cypher.TopLevelSortWithExpensiveCypher 13725 13658 92 139 2174
sorting-and-cypher.TopLevelConnectionSortWithExpensiveCypher 13266 13266 102 143 2174
sorting.SortMultipleTypes 3436 3436 81 100 1040
sorting.SortMultipleTypesWithCypherWithCypher 13321 13321 99 123 2174
sorting.SortOnNestedFields 12951 12951 44 59 2174
sorting.SortDeeplyNestedFields 39785 39785 81 99 4516
sorting.ConnectionWithSort 3271 3271 69 82 1040
unions.SimpleUnionQuery 321 321 70 61 35
unions.SimpleUnionQueryWithMissingFields 293 293 56 58 35
unions.NestedUnion 309975 309975 276 321 33033
unions.NestedUnionWithMissingFields 283949 283949 257 274 33033
update.NestedUpdate 14137 14137 100 106 2002

Old Schema Generation: 28.745s
Schema Generation: 28.029s
Old Subgraph Schema Generation: 30.145s
Subgraph Schema Generation: 30.497s

@angrykoala angrykoala merged commit 59ccc39 into dev Oct 9, 2024
80 checks passed
@angrykoala angrykoala deleted the update-vector-index-response branch October 9, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants