-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$rootScope.$apply() and terrible performance with multiple files #687
Comments
You could just override the let uploader = new FileUploader(/* options */);
uploader._render = function() {
// $scope is your scope
if(!$scope.$$phase) $scope.$apply();
}; Also you could improve docs about performance issues. |
Thanks, I'll create extended document on the performance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've an application where I use file uploader 2.3.4 at some point, I noticed a drop in performance while a list of just 50
items
was loaded at the same time. After digging a bit I found that this line is called https:/nervgh/angular-file-upload/blame/master/src/services/FileUploader.js#L342 causing ALL the watchers to be fired way too often. This should be handled differently. In my case, I could remove the_render
as uploader renders properly and now adding 300+ files has no hiccupsThe text was updated successfully, but these errors were encountered: