Merge pull request #2952 from voriteam/clintonb/name-bug

fix: Retain $ref when setting name property
nestjs · Jul 1, 2024 · a57f853 · a57f853
2 parents d0a58e0 + 94f565c
commit a57f853
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/services/schema-object-factory.ts b/lib/services/schema-object-factory.ts
@@ -365,7 +365,7 @@ export class SchemaObjectFactory {
  if (metadata.isArray) {
  return this.transformToArraySchemaProperty(metadata, key, { $ref });
  }
- const keysToRemove = ['type', 'isArray', 'required'];
+ const keysToRemove = ['type', 'isArray', 'required', 'name'];
  const validMetadataObject = omit(metadata, keysToRemove);
  const extraMetadataKeys = Object.keys(validMetadataObject);
 

diff --git a/test/services/fixtures/create-profile.dto.ts b/test/services/fixtures/create-profile.dto.ts
@@ -10,7 +10,8 @@ export class CreateProfileDto {
  lastname: string;
 
  @ApiProperty({
- type: () => CreateUserDto
+ type: () => CreateUserDto,
+ name: 'parent'
  })
  parent: CreateUserDto;
 }