15802 change table anchor color #15841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Apr 25, 2024
There was a problem hiding this comment.
However it doesn't have any contrast between a link and a non-link (see screenshot) not sure if we want this or to go with a different tabler link color...
We definitely still want to render links in a different color. #15802 is just to increase the contrast of links under dark mode.
jeremystretch
requested changes
May 1, 2024
|
I tried using different media queries but they didn't work properly when switching between light and dark, even specifically defining media queries for both. As a compromise I picked a filter to slightly lighten the link which seems to look fairly good in both light and dark. |
jeremystretch
requested changes
May 2, 2024
jeremystretch
approved these changes
May 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15802
Made a lighter version of the current link color for tables