Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

unbound module #287

Merged
merged 39 commits into from
Nov 21, 2019
Merged

unbound module #287

merged 39 commits into from
Nov 21, 2019

Conversation

ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Nov 14, 2019

@codecov-io
Copy link

codecov-io commented Nov 14, 2019 •
edited
Loading

Codecov Report

Merging #287 into master will increase coverage by 0.58%.
The diff coverage is 89.33%.

@ilyam8 ilyam8 changed the title [wip] unbound module unbound module Nov 19, 2019
joelhans
joelhans suggested changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@joelhans joelhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a few things. Nothing too major!

modules/unbound/README.md Outdated Show resolved Hide resolved
modules/unbound/README.md Outdated Show resolved Hide resolved
modules/unbound/README.md Outdated Show resolved Hide resolved
modules/unbound/README.md Show resolved Hide resolved
modules/unbound/README.md Outdated Show resolved Hide resolved
modules/unbound/README.md Outdated Show resolved Hide resolved
modules/unbound/README.md Outdated Show resolved Hide resolved
modules/unbound/README.md Outdated Show resolved Hide resolved
modules/unbound/README.md Outdated Show resolved Hide resolved
modules/unbound/README.md Outdated Show resolved Hide resolved
joelhans
joelhans approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@joelhans joelhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I know the h2 is a little big, but that will get better on the Learn site, and having the right nesting won't throw linter errors.

@ilyam8 ilyam8 merged commit fc8adcd into netdata:master Nov 21, 2019
@ilyam8 ilyam8 deleted the unbound branch December 3, 2019 20:14
boxjan pushed a commit to AgoraLab/go.d.plugin that referenced this pull request Feb 9, 2022
@ilyam8
unbound module (netdata#287)
746a7b2 
* unbound module
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joelhans joelhans joelhans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unbound queries data-desired-units
3 participants
@ilyam8 @codecov-io @joelhans