Improve processing on removed alerts after agent restart #18488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stelfrag
added a commit
to stelfrag/netdata
that referenced
this pull request
Sep 6, 2024
Record current unique_id not previous one (cherry picked from commit b86d3b2) Improve processing of pending alerts (netdata#18470) Delete only processed alerts (cherry picked from commit 7f70ffb)
Merged
stelfrag
added a commit
to stelfrag/netdata
that referenced
this pull request
Sep 6, 2024
Record current unique_id not previous one (cherry picked from commit b86d3b2)
Ferroin
pushed a commit
that referenced
this pull request
Sep 10, 2024
Record current unique_id not previous one (cherry picked from commit b86d3b2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is a bug when scheduling removed (deleted) alerts after an agent restart. If an alert has been in WARNING or CRITICAL it is not removed and appears stale.
This PR fixes this issue