Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earth mover's distance and POT dependency #232

Closed
sdmccabe opened this issue Jun 12, 2019 · 3 comments · Fixed by #280
Closed

Earth mover's distance and POT dependency #232

sdmccabe opened this issue Jun 12, 2019 · 3 comments · Fixed by #280
Labels
enhancement New feature or request

Comments

@sdmccabe
Copy link
Collaborator

Ideally we would deprecate the POT dependency and use ortools instead, since it's a headache for the requirements.txt

@leotrs
Copy link
Collaborator

leotrs commented Jun 12, 2019

To be totally fair, the problem comes from a bug in pypi, not pot, as documented here.

I agree the way to go is to replace POT.

@sdmccabe sdmccabe added the enhancement New feature or request label Jun 12, 2019
@sdmccabe
Copy link
Collaborator Author

Related to the POT dependency is that we still have == in our requirements for Cython.

@leotrs
Copy link
Collaborator

leotrs commented Jul 8, 2019

There's been an update on their side, mostly on the documentation side of things. They closed their open issue, though it is unclear that their new PR actually solves our problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants