Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: moved get_info from backend.py to _nx_parallel #53

Merged
merged 3 commits into from
Mar 16, 2024

Conversation

Schefflera-Arboricola
Copy link
Member

@Schefflera-Arboricola Schefflera-Arboricola commented Mar 15, 2024

Please do "Squash and merge" while merging this PR

fixes #52

for ref. #27

@Schefflera-Arboricola Schefflera-Arboricola marked this pull request as draft March 15, 2024 15:17
@dschult dschult added the type: Bug fix Something isn't working label Mar 15, 2024
@dschult
Copy link
Member

dschult commented Mar 15, 2024

I don;t think you need to make the additional parameters dict. It is a helpful structure if you already know the parameter names and corresponding docs. But when you are pulling from existing doc_strings on these functions, it is probably easier to just extend the additional_docs string with the parameter descriptions.

That is: you can add the parameter section of the doc_strings to the additional_docs field (leaving additional_parameters blank) rather than parsing and making the dict structure required for additional_parameters`.

Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Let’s try it.
The failing test is unrelated.

@dschult dschult merged commit 57bdb07 into networkx:main Mar 16, 2024
10 of 11 checks passed
@jarrodmillman jarrodmillman added this to the 0.1 milestone Mar 16, 2024
@jarrodmillman jarrodmillman modified the milestones: 0.1, 0.2 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Bug fix Something isn't working
Development

Successfully merging this pull request may close these issues.

RuntimeWarning when loading parallel backend
3 participants