Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: updated README and _nx_parallel/__init__.py #58

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

Schefflera-Arboricola
Copy link
Member

README.md Outdated
Comment on lines 77 to 78
nx.algorithms.connectivity.connectivity.all_pairs_node_connectivity(H)
nx.algorithms.approximation.connectivity.all_pairs_node_connectivity(H)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NetworkX has a pretty flat namespace that doesn't correspond with the file structure. So these calls
using the full file path are typically not used (even for backend calling). The expected way to call these as a backend would be:

nx.all_pairs_node_connectivity(H)
nx.approximation.all_pairs_node_connectivity(H)

Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@dschult dschult merged commit 4600630 into networkx:main Apr 4, 2024
11 checks passed
@jarrodmillman jarrodmillman added this to the 0.1 milestone Apr 4, 2024
@jarrodmillman jarrodmillman modified the milestones: 0.1, 0.2 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants