Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming Parser01 #9

Closed
adamltyson opened this issue Dec 5, 2022 · 3 comments
Closed

Consider renaming Parser01 #9

adamltyson opened this issue Dec 5, 2022 · 3 comments
Assignees

Comments

@adamltyson
Copy link
Member

It's not clear what this is. A more easily grokable term would make it easier to read the code.

@lauraporta
Copy link
Member

What about Parser2pRSP? It stands for parser two photon, and RSP is a reference to the original project.
I don't fully like the idea of having a parsing class dedicated to each project / folder struct. I don't think that's scalable. However I did't yet figured out a better alternative.

@adamltyson
Copy link
Member Author

What about Parser2pRSP?

Fine by me.

I don't fully like the idea of having a parsing class dedicated to each project / folder struct. I don't think that's scalable. However I did't yet figured out a better alternative.

I would suggest creating N parsing classes for existing datasets that need to be supported. To scale from there, we could promote a standardised file structure that would be supported by one additional, general-purpose parser.

@lauraporta
Copy link
Member

Makes sense. And then if someone else want to use it with a different folder structure it will still be possible to add an n+1 parser in a forked version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants