-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform the analysis also by pooling data from all directions #56
Conversation
…-unit/load-suite2p into feature/pool-directions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review summary
Great job @lauraporta. I found the code very well written and easy to follow. Reading the README and the presentation helped me a lot.
I've left a bunch of comments for things that were not entirely clear to me, but mostly they are about typos or pedantic stuff about variable and function names. The most confusing part is the thing about the "mean of medians" and calculating stuff with directions pooled or not. Maybe some equations/diagrams would help with this.
Other than that, nothing substantial to say.
P.S:
This doesn't belong on this PR, but I'll say it here so I don't forget. It's probably not worth storig the gaussian matrices in the pickle file. The time-consuming step is probably the fitting. You can just store the fit parameters, and derive the matrices during the dashboard runtime.
Description
What is this PR
Why is this PR needed?
We would like to see the median subtracted response and the gaussian plots calculated by pooling the directions as well. The statistical tests were already done with this principle.
What does this PR do?
FrequencyResponsiveness
class.pyproject.toml
fileReferences
Does the analysis required for #44.
Giving a look at the readme file could be useful to have an overview of the analysis; there is also a diagram to help you out.
This presentation could help as well.
How has this PR been tested?
The previous tests keep working also given the new functionality
Is this a breaking change?
No
Does this PR require an update to the documentation?
Docstrings for new methods have been added, as well as a general explanation of the package in the readme file.
Checklist: