-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce QC report generation #1251
Conversation
For the commands `sct_propseg`, `sct_label_vertebrae` and `sct_register_to_template`, an extra parameter is added. The parameter takes a output path and generates png images of the input and segmentaion output as well as log of output values. Partial implements #1247
is it ready to be tested? |
@jcohenadad yes it is. |
For the commands `sct_propseg`, `sct_label_vertebrae` and `sct_register_to_template`, an extra parameter is added. The parameter takes a output path and generates png images of the input and segmentaion output as well as log of output values. Partial implements #1247
warning after propseg, then error after sct_qc (the folder ~/qc_data is empty):
|
@jcohenadad can you list me the contents of the |
it is empty |
I do this and nothing happens (nothing in my browser):
Update: if i copy/paste URL in browser, it works. But people cannot guess it. Possible to open browser automatically? If not, indicate to the user that he/she has to click on index.html |
can you please make the segmentation blink twice as fast? |
I've added another command for the same subject (label_vertebrae), but when generating the report i only get the view for propseg. |
|
i unchecked some boxes after testing it: thw warning:
and also, after running "sct_label_vertebrae -i t1.nii.gz -s t1_seg.nii.gz -c t1", it does not show up in the html report, nor in the json |
There's a weird bug in makedirs in Python that does not always expand the path before creating the path(s). Thus I force the expansion before creating the folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic contribution 👍
For the commands
sct_propseg
,sct_label_vertebrae
andsct_register_to_template
, an extra parameter is added. The parameter takes aoutput path and generates png images of the input and segmentaion output as well
as log of output values.
Partial implements #1247