Moved the QC assets into the spinalcordtoolbox package #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes it easier to access from within the package and solved the bug when installing SCT in a different path. Fixes #1300
peristeri
added
bug
Moved the assets to `spinalcordtoolbox.reports.assets` and changed the code to look in the new directory.
|
I installed version: move-assets/471bcae92d78f683a2bd41a876b20096fe3a9b3d. I ran batch_processing.sh, and then ran
|
Regression bug fix.
benjamindeleener
approved these changes
May 19, 2017
jcohenadad
approved these changes
May 19, 2017
joshuacwnewton
added a commit
that referenced
this pull request
Jan 17, 2023
E402 was initially added in [#1311](#1311), but currently, it suppresses only a few warnings, all in `registration/algorithms.py`, due to [VoxelMorph's backend settings](https:/spinalcordtoolbox/spinalcordtoolbox/blob/1b5c49c3904dffe63546adbadc47759a53fbc8ca/spinalcordtoolbox/registration/algorithms.py#L24-L27). I think we could easily convert this E402 global exclusion into a `# noqa` comment for VoxelMorph only, to allow us to still catch E402 errors.
joshuacwnewton
added a commit
that referenced
this pull request
Jan 17, 2023
* `setup.cfg`: Remove unnecessary [bdist-wheel] section This is applied when [creating wheel files](https://stackoverflow.com/q/31573107) for a Python package. It denotes a universal wheel, i.e. one that is platform independent. SCT does not create wheels for its `spinalcordtoolbox` package, so this is unnecessary and can be removed. * `setup.cfg`: Remove unnecessary [aliases] section This setting only exists in the context of a _very_ outdated copy of Pytest's documentation: https://docs.pytest.org/en/4.6.x/goodpractices.html#integrating-with-setuptools-python-setup-py-test-pytest-runner We do not use `pytest-runner`, though, nor do we ever execute tests via `python setup.py test`. So, this can be removed. * `setup.cfg`: Remove unnecessary [isort] section [`isort`](https://pycqa.github.io/isort/docs/configuration/config_files.html) is a code-formatting library, similar to `black`, that imposes a strict style on imports at the top of scripts. We don't currently install or use `isort`. * `setup.cfg`: Remove unnecessary flake8 filetype exclusion We don't use `.tox`. But, more importantly, we don't even run `flake8` on the root directory; we only run it on git-tracked files: https:/spinalcordtoolbox/spinalcordtoolbox/blob/1b5c49c3904dffe63546adbadc47759a53fbc8ca/.github/workflows/lint_code.yml#L22 Since our `.gitignore` covers this already, the `exclude` setting can be removed. * `setup.cfg`: Replace `E402` exclusion with `# noqa` comments E402 was initially added in [#1311](#1311), but currently, it suppresses only a few warnings, all in `registration/algorithms.py`, due to [VoxelMorph's backend settings](https:/spinalcordtoolbox/spinalcordtoolbox/blob/1b5c49c3904dffe63546adbadc47759a53fbc8ca/spinalcordtoolbox/registration/algorithms.py#L24-L27). I think we could easily convert this E402 global exclusion into a `# noqa` comment for VoxelMorph only, to allow us to still catch E402 errors. * `setup.cfg`: Remove E501 to make `max-line-length` useful again With E501 set, then `max-line-length` does nothing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes it easier to access from within the package and solved the bug when
installing SCT in a different path.
Fixes #1300