Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch the OSError exception thrown when the git command is missing #1396

Merged
merged 1 commit into from
Jul 5, 2017
Merged

Catch the OSError exception thrown when the git command is missing #1396

merged 1 commit into from
Jul 5, 2017

Conversation

peristeri
Copy link
Contributor

Fixes #1277

@peristeri peristeri added bug category: fixes an error in the code card:TO_REVIEW labels Jul 5, 2017
@peristeri peristeri added this to the Release v3.0.7 milestone Jul 5, 2017
@peristeri peristeri requested a review from jcohenadad July 5, 2017 04:01
jcohenadad
jcohenadad approved these changes Jul 5, 2017
View reviewed changes
Copy link
Member

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested it-- please make sure the except case does work

@peristeri peristeri merged commit 0bde909 into master Jul 5, 2017
@peristeri peristeri deleted the fix-exception branch July 5, 2017 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcohenadad jcohenadad jcohenadad approved these changes

Assignees
No one assigned
Labels
bug category: fixes an error in the code
Projects
None yet
Milestone
Release v3.0.6
Development

Successfully merging this pull request may close these issues.
2 participants
@peristeri @jcohenadad