The params attributes are initialized to the type integer #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The attributes in params are used as indexes to navigate through multidimensional arrays. In addition, removed parameter declarations using `[]` and various other syntax corrections Fixes #1427
peristeri
added
bug
benjamindeleener
previously approved these changes
Aug 1, 2017
jcohenadad
requested changes
Aug 1, 2017
scripts/sct_label_vertebrae.py
Outdated
| @@ -59,7 +59,7 @@ def update(self, param_user): | |||
| if len(object) < 2: | |||
| sct.printv('ERROR: Wrong usage.', 1, type='error') | |||
| obj = object.split('=') | |||
| setattr(self, obj[0], float(obj[1])) | |||
| setattr(self, obj[0], int(obj[1])) | |||
There was a problem hiding this comment.
that doesn't work: gaussian_std needs to be float
benjamindeleener
previously approved these changes
Aug 2, 2017
jcohenadad
requested changes
Aug 2, 2017
scripts/sct_label_vertebrae.py
Outdated
| @@ -139,7 +142,7 @@ def get_parser(): | |||
| "size_AP [mm]: AP window size for disc search. Default=" + str(param_default.size_AP) + ".\n" | |||
| "size_RL [mm]: RL window size for disc search. Default=" + str(param_default.size_RL) + ".\n" | |||
| "size_IS [mm]: IS window size for disc search. Default=" + str(param_default.size_IS) + ".\n" | |||
| "gaussian_std [mm]: STD of the Gaussian function, centered at the most rostral point of the image, " | |||
| "gaussian_std: STD of the Gaussian function, centered at the most rostral point of the image, " | |||
There was a problem hiding this comment.
why did you remove [mm]? Please keep it as the unit is [mm]. Users need to know that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The attributes in params are used as indexes to navigate through
multidimensional arrays. In addition, removed parameter declarations using
[]and various other syntax corrections
Fixes #1427