Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing cropping issue in sct_straighten_spinalcord #1652

Merged
merged 2 commits into from
Mar 24, 2018
Merged

Fixing cropping issue in sct_straighten_spinalcord #1652

merged 2 commits into from
Mar 24, 2018

Conversation

benjamindeleener
Copy link
Contributor

Description of the Change

This PR implements a bug fix for the issue #1478, related to the lack of checking for a crop region in sct_straighten_spinalcord.

Additionally, the PR fixes some print issue for debugging.

Applicable Issues

Fixes #1478

@benjamindeleener benjamindeleener self-assigned this Mar 22, 2018
zougloub
zougloub approved these changes Mar 22, 2018
View reviewed changes
Copy link
Contributor

@zougloub zougloub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK (for printv() arguments you could use str.format or str.__mod__)

@benjamindeleener benjamindeleener merged commit 656f411 into master Mar 24, 2018
@jcohenadad jcohenadad added this to the 3.2.0 milestone May 29, 2018
@jcohenadad jcohenadad added the enhancement category: improves performance/results of an existing feature label May 29, 2018
@jcohenadad jcohenadad deleted the bdl_issue1478 branch August 12, 2018 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zougloub zougloub zougloub approved these changes

@peristeri peristeri Awaiting requested review from peristeri

@jcohenadad jcohenadad Awaiting requested review from jcohenadad

Assignees

@benjamindeleener benjamindeleener

Labels
enhancement category: improves performance/results of an existing feature
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

Error when crop image in sct_straighten_spinalcord after NURBS
3 participants
@benjamindeleener @zougloub @jcohenadad