Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed re-use of the same figure during QC generation #1711

Merged
merged 4 commits into from
May 11, 2018
Merged

Fixed re-use of the same figure during QC generation #1711

merged 4 commits into from
May 11, 2018

Conversation

jcohenadad
Copy link
Member

@jcohenadad jcohenadad commented May 8, 2018 •
edited
Loading

Requirements

  • Is there a issue open describing the motivation for this pull request ?
  • Does the pull request need an update of the documentation ?
  • Does the pull request need additional test(s) ?
  • Clean up the warnings generated by the style guide

Description of the Change

During QC generation, a figure is assigned ID=1 using Agg matplotlib backend (i.e. figure is not displayed on the screen, but is kept opened during the whole processing). If figure(ID=1) does not exist, it is created (normal behaviour). However, if a figure has previously been created and has ID=1, then the same figure is used during QC generation, causing the issue described in #1695.

The solution was to remove the assignment ID=1 so that the ID of the created figure is iterated (e.g. ID=2 if ID=1 exists).

Applicable Issues

Fixes #1695

@jcohenadad jcohenadad changed the title Fixes re-use of the same figure during QC generation Fixed re-use of the same figure during QC generation May 8, 2018
@jcohenadad jcohenadad requested a review from zougloub May 8, 2018 07:06
@jcohenadad jcohenadad self-assigned this May 8, 2018
@jcohenadad jcohenadad added bug category: fixes an error in the code sct_register_to_template context: sct_qc context: labels May 8, 2018
@jcohenadad jcohenadad added this to the 3.1.2 milestone May 8, 2018
zougloub
zougloub approved these changes May 11, 2018
View reviewed changes
Copy link
Contributor

@zougloub zougloub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@zougloub zougloub merged commit ad6727f into master May 11, 2018
@zougloub zougloub deleted the jca_QCreg2template branch May 11, 2018 14:11
jcohenadad pushed a commit that referenced this pull request Dec 18, 2019
@zougloub
Merge pull request #1711 from neuropoly/jca_QCreg2template
0baef6a 
Fixed re-use of the same figure during QC generation

Former-commit-id: ad6727f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zougloub zougloub zougloub approved these changes

Assignees

@jcohenadad jcohenadad

Labels
bug category: fixes an error in the code sct_qc context: sct_register_to_template context:
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jcohenadad @zougloub