Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip URL if filename isn't provided by HTTP server; catch anything in URL try loop #1843

Merged
merged 1 commit into from
Jun 10, 2018
Merged

Skip URL if filename isn't provided by HTTP server; catch anything in URL try loop #1843

merged 1 commit into from
Jun 10, 2018

Conversation

zougloub
Copy link
Contributor

@zougloub zougloub commented Jun 10, 2018 •
edited by jcohenadad
Loading

Fixes #1842

@random1717
Copy link
Contributor

  • If Sentry fails to send warning/error message, we get the "retry message"
  • How does this PR fixes Sentry retry attempts!?

@zougloub
Copy link
Contributor Author

I didn't see such Sentry retry attempts...

@random1717
Copy link
Contributor

@zougloub This one #1842

Sentry is attempting to send 1 pending error messages
Waiting up to 10 seconds
Press Ctrl-C to quit

jcohenadad
jcohenadad approved these changes Jun 10, 2018
View reviewed changes
Copy link
Member

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested: works fine
thanks for the quick fix!!

@jcohenadad jcohenadad merged commit aefec3b into master Jun 10, 2018
@jcohenadad jcohenadad deleted the cJ-misc branch June 10, 2018 21:29
@jcohenadad jcohenadad added sct_download_data context: bug category: fixes an error in the code labels Jun 11, 2018
@jcohenadad jcohenadad added this to the 3.2.1 milestone Jun 11, 2018
@jcohenadad jcohenadad changed the title sct_download_data: skip URL if filename isn't provided by HTTP server… Skip URL if filename isn't provided by HTTP server; catch anything in URL try loop Jun 11, 2018
@jcohenadad jcohenadad mentioned this pull request Jun 11, 2018
Closed
jcohenadad pushed a commit that referenced this pull request Dec 18, 2019
@zougloub @jcohenadad
sct_download_data: skip URL if filename isn't provided by HTTP server…
5c5f64d 
…; catch anything in URL try loop (#1842) (#1843)

Former-commit-id: aefec3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcohenadad jcohenadad jcohenadad approved these changes

@random1717 random1717 Awaiting requested review from random1717

Assignees
No one assigned
Labels
bug category: fixes an error in the code sct_download_data context:
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@zougloub @random1717 @jcohenadad