Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sct_deepseg_gm: Removed restriction on the network input size (small inputs): Fixes bug that appeared when inputting images with small FOV #1877

Merged
merged 4 commits into from
Jun 27, 2018

Conversation

perone
Copy link
Contributor

@perone perone commented Jun 19, 2018

I just realized that given that I can dynamically change the TensorFlow model input size for that particular model architecture that I'm using, it makes it possible to handle input sizes smaller than the sizes that the network was trained on by avoiding padding.

This PR removes the restriction error that we had for smaller volume sizes (after resampling), that was usually thrown when the user inputs a cropped volume. That shouldn't be an issue anymore because now the network input size is dynamically resized (a property of the ASPP architecture allow that). For larger sizes, the process continues the same, with the traditional cropping.

@perone perone added the enhancement category: improves performance/results of an existing feature label Jun 19, 2018
@perone perone self-assigned this Jun 19, 2018
@perone perone requested a review from jcohenadad June 19, 2018 00:08
Copy link
Member

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested: works nicely 👍

@perone perone merged commit fc520c3 into master Jun 27, 2018
@perone perone deleted the perone_deepseg_gm_input_size branch June 27, 2018 14:25
@jcohenadad jcohenadad changed the title Remove sct_deepseg_gm restriction on the network input size (small inputs) sct_deepseg_gm: Removed restriction on the network input size (small inputs): Fixes bug that appeared when inputting images with small FOV Jul 7, 2018
@jcohenadad jcohenadad added this to the v3.2.2 milestone Jul 7, 2018
jcohenadad pushed a commit that referenced this pull request Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement category: improves performance/results of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants