Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sct_label_vertebrae: Added subcortical colormap for fslview #1883

Merged
merged 1 commit into from
Jun 25, 2018
Merged

sct_label_vertebrae: Added subcortical colormap for fslview #1883

merged 1 commit into from
Jun 25, 2018

Conversation

jcohenadad
Copy link
Member

Fixes #1871

@jcohenadad jcohenadad changed the title sct_label_vertebrae: Added colormap for fslview sct_label_vertebrae: Added subcortical colormap for fslview Jun 24, 2018
@jcohenadad jcohenadad self-assigned this Jun 24, 2018
@jcohenadad jcohenadad added bug category: fixes an error in the code sct_label_vertebrae context: labels Jun 24, 2018
@jcohenadad jcohenadad added this to the v3.2.2 milestone Jun 24, 2018
@random1717
Copy link
Contributor

Adding colormap to cmd += ' -l ' + dict_fslview[colormaps[i]]
Seems fine to me if that's the only place we define the dict_fslview

@jcohenadad
Copy link
Member Author

in response to #1883 (comment): yes, that's the only place

@jcohenadad jcohenadad merged commit b24ef4b into master Jun 25, 2018
@jcohenadad jcohenadad deleted the jca_issue1871 branch June 25, 2018 05:09
jcohenadad added a commit that referenced this pull request Dec 18, 2019
@jcohenadad
added option for fslview (fixed issue 1871) (#1883)
e6fd3e2 
Former-commit-id: b24ef4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@random1717 random1717 random1717 approved these changes

Assignees

@jcohenadad jcohenadad

Labels
bug category: fixes an error in the code sct_label_vertebrae context:
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jcohenadad @random1717