sct_register_multimodal: Fixed bug when using partial mask with algo=slicereg #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcohenadad
changed the title
|
tricky blockage with integrity testing of On Travis/Linux/Python2.7/Miniconda2: On my macbook (OSX 10.13): this needs to be fixed before merging. UPDATE 2018-07-11 22.53: my mistake ( i had a corrupted testing data) |
zougloub
approved these changes
Jul 12, 2018
scripts/msct_image.py
Outdated
| continue_zmin_search = False | ||
| # the following if statement deals with zmax search | ||
| if np.any(dataz > threshold): | ||
| zmax = iz |
There was a problem hiding this comment.
nice! it works and it does blow my mind (i have a low threshold). I'll merge cJ/msct_image-new-slicer-that-blows-your-mind on jca/1666.
jcohenadad
added a commit
that referenced
this pull request
Dec 18, 2019
…slicereg (#1917) * fixed indent for PEP8 * refactored msct_image.find_zmin_zmax: need to udpate register_to_template (WIP) * now account for mask coverage when cropping before slicereg (fixes #1666) * fixed compatibility of register_to_template with recent modification find_zmin_zmax() * TEST: label_utils: updated results due to change in numerical precision * cleanup * TEST: reverted back to previous integrity testing value (my mistake) * msct_image: add a slicer! * improve find_zmin_zmax() with slicer magic * msct_image: fixup typo (please squash) Former-commit-id: ed7d66b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixes #1666