Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug in method max #2087

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Fixed bug in method max #2087

merged 1 commit into from
Nov 30, 2018

Conversation

jcohenadad
Copy link
Member

Methods max was falsely computed (regression bug). This PR fixes it.

Fixes #2086

@jcohenadad jcohenadad added bug category: fixes an error in the code sct_extract_metric context: labels Nov 30, 2018
@jcohenadad jcohenadad self-assigned this Nov 30, 2018
@jcohenadad jcohenadad added this to the v3.3 milestone Nov 30, 2018
@jcohenadad jcohenadad merged commit 3c03342 into master Nov 30, 2018
@jcohenadad jcohenadad deleted the jca/2086-extract-metric-max-wa branch November 30, 2018 03:47
jcohenadad added a commit that referenced this pull request Dec 18, 2019
@jcohenadad
sct_extract_metric: Fixed method max (#2087)
b0e52ac 
Fixed #2086

Former-commit-id: 3c03342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleygros charleygros charleygros approved these changes

Assignees

@jcohenadad jcohenadad

Labels
bug category: fixes an error in the code sct_extract_metric context:
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

method max and wa give the same results
2 participants
@jcohenadad @charleygros