Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash caused by wrong estimation of centerline length in case of incomplete segmentation #2154

Merged
merged 3 commits into from
Feb 11, 2019

Conversation

jcohenadad
Copy link
Member

This PR fixes extreme cases where the segmentation is incomplete, causing straightening to crash. There is also speed improvement (less i/o).

Fixes #2153

@jcohenadad jcohenadad changed the title Jca/2153 straightening Fixed crash caused by wrong estimation of centerline length in case of incomplete segmentation Feb 11, 2019
@jcohenadad jcohenadad added bug category: fixes an error in the code sct_straighten_spinalcord context: labels Feb 11, 2019
@jcohenadad jcohenadad added this to the v4.0.0 milestone Feb 11, 2019
@jcohenadad jcohenadad merged commit 7960a3f into master Feb 11, 2019
@jcohenadad jcohenadad deleted the jca/2153-straightening branch February 11, 2019 21:19
jcohenadad added a commit that referenced this pull request Dec 18, 2019
…f incomplete segmentation (#2154)

* sct_straighten_spinalcord: Restricting centerline to seg min/max

to prevent issue #2153

* centerline/core: Changed default for minmax=True

To maximize cross-compatibility

* sct_straighten_spinalcord: Reduced i/o


Former-commit-id: 7960a3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug category: fixes an error in the code sct_straighten_spinalcord context:
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash caused by wrong estimation of centerline length
2 participants