Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output segmentation in uint8 when input is float #2297

Merged
merged 2 commits into from
Jun 5, 2019
Merged

Output segmentation in uint8 when input is float #2297

merged 2 commits into from
Jun 5, 2019

Conversation

charleygros
Copy link
Member

This PR simply changes output segmentation data type to uint8 for deepseg_sc and deepseg_lesion.

To reproduce:

cd duke/sct_testing/bids/sct-users/sub-20190427/anat
sct_deepseg_sc -i sub-20190427_acq-MTon_MTS.nii.gz -c t2s

Fixes #2243.

@charleygros charleygros added bug category: fixes an error in the code sct_deepseg_sc context: sct_deepseg_lesion context: labels Jun 5, 2019
@charleygros charleygros self-assigned this Jun 5, 2019
YangHee-Min
YangHee-Min approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@YangHee-Min YangHee-Min left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me

jcohenadad
jcohenadad approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcohenadad jcohenadad added enhancement category: improves performance/results of an existing feature and removed bug category: fixes an error in the code labels Jun 5, 2019
@charleygros charleygros merged commit 5727535 into master Jun 5, 2019
@jcohenadad jcohenadad added this to the v4.0.0 milestone Jun 5, 2019
@charleygros charleygros deleted the cg/deepseg-output-int8 branch June 5, 2019 13:52
@jcohenadad jcohenadad changed the title Output segmentation in uint8 Output segmentation in uint8 when input is float Jun 5, 2019
jcohenadad pushed a commit that referenced this pull request Dec 18, 2019
@charleygros
Merge pull request #2297 from neuropoly/cg/deepseg-output-int8
1d82df9 
Output segmentation in uint8

Former-commit-id: 5727535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcohenadad jcohenadad jcohenadad approved these changes

@YangHee-Min YangHee-Min YangHee-Min approved these changes

Assignees

@charleygros charleygros

Labels
enhancement category: improves performance/results of an existing feature sct_deepseg_lesion context: sct_deepseg_sc context:
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Running deepseg on float output a segmentation in float
3 participants
@charleygros @jcohenadad @YangHee-Min