Fixed issue that appeared when trying to remove temporary folder from different file systems #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also using distutils instead of shutil, to copy directories that might not be empty. Addressed issue #2472
|
@baxpr could you please test this branch and let me know how it goes? |
jcohenadad
added
installation
jcohenadad
referenced
this pull request
Oct 3, 2019
|
@jcohenadad Thanks for this! I tested, and it does fix my singularity build problem. |
jcohenadad
added a commit
that referenced
this pull request
Dec 18, 2019
… different file systems (#2473) * install_sct: replaced hard-coded bin by $BIN_DIR * sct_download_data: Now copying folder instead of moving it Also using distutils instead of shutil, to copy directories that might not be empty. Addressed issue #2472 * sct_download_data: No more removal of existing file in dest folder Former-commit-id: ba29abbae261e65ee162db200a04e6b59ad782ad [formerly 6129e20 [formerly 0dbbcbf]] Former-commit-id: cbe2ccac7f1151db34675a51d906307859485f3e Former-commit-id: 3701e58
jcohenadad
added a commit
that referenced
this pull request
Dec 18, 2019
… different file systems (#2473) * install_sct: replaced hard-coded bin by $BIN_DIR * sct_download_data: Now copying folder instead of moving it Also using distutils instead of shutil, to copy directories that might not be empty. Addressed issue #2472 * sct_download_data: No more removal of existing file in dest folder Former-commit-id: 0dbbcbf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accommodates fixes an issue that appeared when installing SCT under Singulary container, where a folder located in another file system could not be moved.
The implemented solution is to copy the files (instead of moving them). This PR also includes a few minor improvements, notably by replacing shutil by distutils for copying files to existing directories (not possible with shutil.copytree).
Fixes #2472