Fixed deprecation with adaptative thresholding #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because this is not otsu
jcohenadad
added
bug
charleygros
approved these changes
Oct 4, 2019
jcohenadad
added a commit
that referenced
this pull request
Dec 18, 2019
* sct_maths: Replaced deprecated threshold_adaptive by threshold_local Fixes #2471 * sct_maths: Changed flag: -otsu-adap --> -adap because this is not otsu Former-commit-id: 928f46e9807beb1817e2f095d2b340fe71c03e9b [formerly ce38d6f [formerly eb65a84]] Former-commit-id: 500578b0ac4cc96ac8b58f5004cfa3f62dcb6950 Former-commit-id: 1305a75
jcohenadad
added a commit
that referenced
this pull request
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The skimage function
threshold_adaptive()has been deprecated, so this PR replaces it with the equivalentthreshold_local(). This PR also includes slight clarifications in the usage.Fixes #2471