Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed generation of QC report #2567

Merged
merged 6 commits into from
Jan 7, 2020
Merged

Fixed generation of QC report #2567

merged 6 commits into from
Jan 7, 2020

Conversation

jcohenadad
Copy link
Member

A bug related to the new definition of spinalcordtoolbox.metadata.get_file_label() prevented the generation of the QC report, because the label "white matter" was recently renamed in "mask white matter (probabilistic)". This PR fixes the problem by simply removing the useless if statement.

Fixes #2564

@jcohenadad jcohenadad added bug category: fixes an error in the code sct_warp_template context: labels Jan 6, 2020
@jcohenadad jcohenadad added this to the 4.2.1 milestone Jan 6, 2020
Copy link
Contributor

@olix86 olix86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super familiar with this code, but looks fine to me 👍

@jcohenadad jcohenadad merged commit ee43a28 into master Jan 7, 2020
@jcohenadad jcohenadad deleted the jca/2564-warp-template-qc branch January 7, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug category: fixes an error in the code sct_warp_template context:
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting message "QC not generated since expected labels are missing from template" whereas QC can be generated
2 participants