-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate null response on httpclient5 #1649
Labels
Milestone
Comments
kford-newrelic
added
estimate
Issue needing estimation
jan-mar qtr
Represents proposed work item for the Jan-Mar quarter
1
Story Point Estimate
and removed
estimate
Issue needing estimation
labels
Dec 7, 2023
Additional reference - NR-214951 |
Resolved by: #1719 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
In some cases, after an async request is made using httpclient5, the call is completed and a null Object is passed as the response.
This causes an NPE when the instrumentation is trying to get the http response code. Further, this prevents a segment from being finished, causing the transaction to appear to have taken 10 minutes (due to segment timeout).
Acceptance Criteria
Code is guarded to prevent NPE when the response is being read at
newrelic-java-agent/instrumentation/httpclient-5.0/src/main/java/com/nr/agent/instrumentation/httpclient50/InstrumentationUtils.java
Line 80 in 9f144fd
Also, end the segment in a finally block.
The text was updated successfully, but these errors were encountered: