Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate null response on httpclient5 #1649

Closed
meiao opened this issue Dec 7, 2023 · 3 comments
Closed

Investigate null response on httpclient5 #1649

meiao opened this issue Dec 7, 2023 · 3 comments
Assignees
Labels
1 Story Point Estimate jan-mar qtr Represents proposed work item for the Jan-Mar quarter

Comments

@meiao
Copy link
Contributor

meiao commented Dec 7, 2023

Description

In some cases, after an async request is made using httpclient5, the call is completed and a null Object is passed as the response.

This causes an NPE when the instrumentation is trying to get the http response code. Further, this prevents a segment from being finished, causing the transaction to appear to have taken 10 minutes (due to segment timeout).

Acceptance Criteria

Code is guarded to prevent NPE when the response is being read at

Also, end the segment in a finally block.

@workato-integration
Copy link

@kford-newrelic kford-newrelic added estimate Issue needing estimation jan-mar qtr Represents proposed work item for the Jan-Mar quarter 1 Story Point Estimate and removed estimate Issue needing estimation labels Dec 7, 2023
@kford-newrelic
Copy link
Contributor

Additional reference - NR-214951

@jbedell-newrelic
Copy link
Contributor

Resolved by: #1719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 Story Point Estimate jan-mar qtr Represents proposed work item for the Jan-Mar quarter
Projects
Archived in project
Development

No branches or pull requests

3 participants