JdbcHelper urlTofactory Map replacement #1114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the existing ConcurrentHashMap used for the
urlToFactory
andurlToDatabaseName
maps with a simple, custom cache that can expire items in the cache based on the last time an item was accessed.The ConcurrentHashMap implementations were causing issues when used with MySql replication, where URLs to target replica databases were comprised of unique, generated Strings, causing the maps to grow without bound, which could eventually cause an OOM exception.