Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database and external span attributes to correlate to metric data (Duplicate) #1525

Merged
merged 9 commits into from
Oct 6, 2023

Conversation

obenkenobi
Copy link
Contributor

This is a duplicate of the following PR.

Overview

This adds attributes to Spans so that we can correlate aggregate database and external metric back to their related client spans.

  • db.system
  • db.operation
  • db.collection
  • server.address
  • server.port

https://opentelemetry.io/docs/specs/otel/trace/semantic_conventions/http/
https://opentelemetry.io/docs/specs/otel/trace/semantic_conventions/database/

Related Github Issue

Include a link to the related GitHub issue, if applicable

Testing

I added unit tests to cover the new attributes. I can a couple of local apps with a local build and verified that the attributes were correctly added.

Checks

[ X ] Are your contributions backwards compatible with relevant frameworks and APIs?
[ ] Does your code contain any breaking changes? Please describe.
[ ] Does your code introduce any new dependencies? Please describe.

@sdaubin
Copy link
Contributor

sdaubin commented Oct 4, 2023

@obenkenobi @jtduffy will this be merged soon? Do you need help with anything?

@meiao
Copy link
Contributor

meiao commented Oct 5, 2023

Fixes #1478

@jtduffy
Copy link
Contributor

jtduffy commented Oct 6, 2023

@sdaubin Sorry for the delay.
There are failing unit tests in com.newrelic.agent.tracers.DefaultSqlTracerTest:

  • testSpanEventDatastoreTruncationAtExactLimit
  • testSpanEventDatastoreTruncation
  • testSpanEventDatastore

@obenkenobi obenkenobi merged commit 9b4c2fe into main Oct 6, 2023
103 checks passed
@obenkenobi obenkenobi deleted the saxon-db-attr-pr-dup branch May 2, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants