Add database and external span attributes to correlate to metric data (Duplicate) #1525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate of the following PR.
Overview
This adds attributes to Spans so that we can correlate aggregate database and external metric back to their related client spans.
https://opentelemetry.io/docs/specs/otel/trace/semantic_conventions/http/
https://opentelemetry.io/docs/specs/otel/trace/semantic_conventions/database/
Related Github Issue
Include a link to the related GitHub issue, if applicable
Testing
I added unit tests to cover the new attributes. I can a couple of local apps with a local build and verified that the attributes were correctly added.
Checks
[ X ] Are your contributions backwards compatible with relevant frameworks and APIs?
[ ] Does your code contain any breaking changes? Please describe.
[ ] Does your code introduce any new dependencies? Please describe.