Deprecate browser footer injection APIs;header injection now adds both scripts #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1679 +/- ##
============================================
- Coverage 70.71% 70.70% -0.01%
+ Complexity 9953 9935 -18
============================================
Files 828 828
Lines 39940 39877 -63
Branches 6032 6030 -2
============================================
- Hits 28243 28195 -48
+ Misses 8978 8962 -16
- Partials 2719 2720 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
For the methods that are now noops, should we also update the Javadoc comments to call this out - and perhaps reference the header-only method that essentially replaces it?
There was a problem hiding this comment.
The javadoc in PublicApi.java contains the information regarding the deprecation/replacements of the footer related methods.
meiao
approved these changes
Jan 9, 2024
| * * SPDX-License-Identifier: Apache-2.0 | ||
| * | ||
| */ | ||
|
|
||
| package com.newrelic.agent.browser; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #1657
This change deprecates the browser footer API (
getBrowserTimingFooter) and changes the behavior of the browser header API/instrumentation ('getBrowserTimingHeader) to now include both scripts in the` element.Calling the browser footer API returns an empty string.
Testing
The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
Checks