NR-134815 Treat OTel WithSpan annotation as Trace #1841
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NR-134815
Overview
There is a java OpenTelemetry library that contains a
WithSpan
annotation designed to work the same as ourTrace
annotation. By adding support for this annotation we increase our adoption of Otel. It allows customers to use this open source annotation instead of our proprietary annotation (in many cases).I think we can defer suppressing this instrumentation (
otel.instrumentation.opentelemetry-instrumentation-annotations.exclude-methods
) and adding support forotel.instrumentation.methods.include
until later.Note that OTel properties can be set through environment or system properties, like our agent, and eventually through a config file. We can use our existing otel instrumentation model to get access to the normalized version of the instrumentation settings to include and exclude methods and pass those to the core agent through the bridge.
https://opentelemetry.io/docs/languages/java/automatic/annotations/
Related Github Issue
https://new-relic.atlassian.net/issues/NR-134815
Testing
The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
Checks