JSP v3 Tag library instrumentation for RUM script injection #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1943 +/- ##
============================================
- Coverage 70.66% 69.81% -0.85%
+ Complexity 9858 9757 -101
============================================
Files 826 826
Lines 39804 39792 -12
Branches 6062 6061 -1
============================================
- Hits 28127 27781 -346
- Misses 8951 9329 +378
+ Partials 2726 2682 -44 ☔ View full report in Codecov by Sentry. |
jbedell-newrelic
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1695
Injection of the Real User Monitoring Script Via JSP Tag Libraries
Prior to the additions to this instrumentation module, the only way to inject the RUM script into JSPs was during the
compilation phase of the Jasper compiler, which injects the script into the HTML
<head>element, if present in the pagesource.
Some applications use custom JSP tag libraries to create the head tag (and other HTML page elements). In this scenario, the RUM script will not be injected because of the way the Jasper compiler instrumentation detects the head tag. This
instrumentation module weaves the
SimpleTagSupportandTagSupportclasses to detect the creation of head elements via the tag execution and inject the RUM script at that time.See the included README for more information.