Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HikariCP 2.4.0 module #1964

Merged
merged 3 commits into from
Jul 1, 2024
Merged

HikariCP 2.4.0 module #1964

merged 3 commits into from
Jul 1, 2024

Conversation

jtduffy
Copy link
Contributor

@jtduffy jtduffy commented Jun 28, 2024

Supports HikariCP 2.4 to current. Replaces the HikariCP extension module.

Every 5 seconds, the following metrics will be reported:

  • Database Connection/HikariCP/{PoolName}/Busy Count[connections]: Retrieved from the HikariPoolMXBean instance
  • Database Connection/HikariCP/{PoolName}/Idle Count[connections]: Retrieved from the HikariPoolMXBean instance
  • Database Connection/HikariCP/{PoolName}/Max Pool Size[connections]: Retrieved from the HikariConfig instance

@jtduffy jtduffy requested a review from a team June 28, 2024 15:18
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.60%. Comparing base (ecb58c1) to head (03fa992).
Report is 8 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1964      +/-   ##
============================================
- Coverage     70.63%   70.60%   -0.04%     
- Complexity     9860     9862       +2     
============================================
  Files           827      827              
  Lines         39835    39857      +22     
  Branches       6066     6068       +2     
============================================
+ Hits          28139    28142       +3     
- Misses         8970     8986      +16     
- Partials       2726     2729       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtduffy jtduffy merged commit 6bb98c4 into main Jul 1, 2024
111 checks passed
@jtduffy jtduffy deleted the hikaricp-24 branch July 1, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants